Fix Wimplicit-int-conversion-on-negation#355
Closed
Conarnar wants to merge 1 commit into
Closed
Conversation
bjosv
reviewed
Aug 18, 2025
| if ((sign = n < 0)) { | ||
| *p++ = '-'; | ||
| n = -n; | ||
| n = (int8_t)-n; |
Collaborator
There was a problem hiding this comment.
An alternative seems to be n *= -1; which also silences the warning..but I don't know if that is a glitch in clang.
Feels like that also would be an implicit conversion due to integer promotion.
bjosv
approved these changes
Aug 18, 2025
Contributor
|
It seems this fix has found its way from other commit, so I'll close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clang 21 adds the warning Wimplicit-int-conversion-on-negation which is when a smaller integer type (char, short) is negated and then converted back to to the smaller type, since negation implicitly converts the value to int.
Adding the casts here should stop the warning.